Updated api endpoint from /users/self to /users?profile=true #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashchoudhary07
approved these changes
Dec 8, 2024
|
@Hariom01010 Please check, Tests are failing |
prakashchoudhary07
requested changes
Dec 8, 2024
|
|
Hello Prakash sir, I tried to reproduce the failing tests as follows:
Now all tests are passing for some reason. So i am not able to reproduce it. So i have created a new branch and will be closing this PR and create a new PR from that branch and the test result is OK there. Will attach the screenshot too sir. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 07 Dec 2024
Developer Name: Hariom Vashista
Issue Ticket Number:-
Real-Dev-Squad/todo-action-items#255 repo#2
Description:
Add description of the PR here
This PR aims to remove the deprecated API endpoint /users/self and update it with /users?profile=true
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )